-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Add set functions [Array API] #619
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
==========================================
- Coverage 90.43% 90.36% -0.07%
==========================================
Files 20 20
Lines 3564 3601 +37
==========================================
+ Hits 3223 3254 +31
- Misses 341 347 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give this a more in-depth review later, but here are some high-level suggestions.
Okay, so I looked through the standard -- For |
For |
for more information, see https://pre-commit.ci
I removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last set of comments otherwise LGTM.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for your work on this.
Hi @hameerabbasi,
This PR adds four set functions for COO format described in the Array API standard:
unique_all
unique_counts
unique_inverse
unique_values